Re: [Qemu-devel] [PATCH] monitor: Fix gva2gpa coverityism

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 08:01:40PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Coverity is complaining that while I'm checking the return > value of mon_get_cpu(), I'm not actually using the checked value, > I'm calling it again and thus it's worried I might ge

[Qemu-devel] [PATCH] monitor: Fix gva2gpa coverityism

2019-05-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Coverity is complaining that while I'm checking the return value of mon_get_cpu(), I'm not actually using the checked value, I'm calling it again and thus it's worried I might get null; I don't think that's actually possible since i'm under lock anyway. However, it'