Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-08 Thread Blue Swirl
On Fri, Sep 7, 2012 at 3:25 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 7 September 2012 15:53, Jan Kiszka jan.kis...@web.de wrote: On 2012-09-07 16:41, Peter Maydell wrote: On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: +

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-08 Thread Jan Kiszka
On 2012-09-08 10:44, Blue Swirl wrote: On Fri, Sep 7, 2012 at 3:25 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 7 September 2012 15:53, Jan Kiszka jan.kis...@web.de wrote: On 2012-09-07 16:41, Peter Maydell wrote: On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: +

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Peter Maydell
On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: The old arithmetic assumed 32 physical address bits which is no longer true for ARM since 3cc0cd61f4. Signed-off-by: Jan Kiszka jan.kis...@web.de --- hw/musicpal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Jan Kiszka
On 2012-09-07 16:41, Peter Maydell wrote: On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: The old arithmetic assumed 32 physical address bits which is no longer true for ARM since 3cc0cd61f4. Signed-off-by: Jan Kiszka jan.kis...@web.de --- hw/musicpal.c |4 ++-- 1 files

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Peter Maydell
On 7 September 2012 15:53, Jan Kiszka jan.kis...@web.de wrote: On 2012-09-07 16:41, Peter Maydell wrote: On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: +pflash_cfi02_register(0x1-MP_FLASH_SIZE_MAX, NULL, I don't think this will compile on a 32 bit system, will

[Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-06 Thread Jan Kiszka
The old arithmetic assumed 32 physical address bits which is no longer true for ARM since 3cc0cd61f4. Signed-off-by: Jan Kiszka jan.kis...@web.de --- hw/musicpal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index ad725b5..10c2c16