Re: [Qemu-devel] [PATCH] net/socket: remove hardcoded packet size in favor of new mtu parameter

2011-05-15 Thread Michael S. Tsirkin
On Fri, Apr 22, 2011 at 07:59:28PM +0700, Nguyễn Thái Ngọc Duy wrote: Also mention the default value 4096. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com IS the option really necessary? Why not just allocate 128K or so and be done with it? That should be big enough even with GSO etc.

Re: [Qemu-devel] [PATCH] net/socket: remove hardcoded packet size in favor of new mtu parameter

2011-05-15 Thread Nguyen Thai Ngoc Duy
2011/5/16 Michael S. Tsirkin m...@redhat.com: On Fri, Apr 22, 2011 at 07:59:28PM +0700, Nguyễn Thái Ngọc Duy wrote: Also mention the default value 4096. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com IS the option really necessary? Why not just allocate 128K or so and be done with

Re: [Qemu-devel] [PATCH] net/socket: remove hardcoded packet size in favor of new mtu parameter

2011-04-23 Thread Stefan Hajnoczi
2011/4/22 Nguyễn Thái Ngọc Duy pclo...@gmail.com: Also mention the default value 4096. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com ---  free new buffers in net_socket_cleanup()  net.c           |    4  net/socket.c    |   52

Re: [Qemu-devel] [PATCH] net/socket: remove hardcoded packet size in favor of new mtu parameter

2011-04-22 Thread Stefan Hajnoczi
2011/4/22 Nguyễn Thái Ngọc Duy pclo...@gmail.com: @@ -288,6 +291,10 @@ static NetSocketState *net_socket_fd_init_dgram(VLANState *vlan,     s = DO_UPCAST(NetSocketState, nc, nc); +    s-mtu = mtu; +    s-buf = qemu_malloc(s-mtu); +    s-buf1 = qemu_malloc(s-mtu); These need to be freed

[Qemu-devel] [PATCH] net/socket: remove hardcoded packet size in favor of new mtu parameter

2011-04-22 Thread Nguyễn Thái Ngọc Duy
Also mention the default value 4096. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- free new buffers in net_socket_cleanup() net.c |4 net/socket.c| 52 qemu-options.hx | 11 ++- 3 files changed,

[Qemu-devel] [PATCH] net/socket: remove hardcoded packet size in favor of new mtu parameter

2011-04-21 Thread Nguyễn Thái Ngọc Duy
Also mention the default value 4096. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- I have a driver that sends 4352 byte packets. Tested with tcp socket only. There's also 4096 byte buffers in vde, but I don't use/test it. net.c |4 net/socket.c| 54