Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

2016-01-12 Thread Miao Yan
2016-01-12 15:57 GMT+08:00 Dmitry Fleytman : > >> On 12 Jan 2016, at 09:23 AM, Miao Yan wrote: >> >> Hi Dmitry, >> >> 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : >>> On 12 Jan 2016, at 04:38 AM, Miao Yan

[Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

2016-01-11 Thread Miao Yan
Turning debug printfs to trace points for register access Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 68 +--- trace-events | 6 + 2 files changed, 16 insertions(+), 58 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

2016-01-11 Thread Dmitry Fleytman
> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: > > Turning debug printfs to trace points for register access Hello Miao! While I’m into adding trace points I don’t really like the decrease of logs usability introduced by this patch. Current code produces clear human

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

2016-01-11 Thread Dmitry Fleytman
> On 12 Jan 2016, at 09:23 AM, Miao Yan wrote: > > Hi Dmitry, > > 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : >> >>> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: >>> >>> Turning debug printfs to trace points for register

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

2016-01-11 Thread Miao Yan
Hi Dmitry, 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : > >> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: >> >> Turning debug printfs to trace points for register access > > Hello Miao! > > While I’m into adding trace points I don’t really like the