Re: [Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-17 Thread Max Reitz
On 17.06.19 08:54, Klaus Birkelund wrote: > On Fri, Jun 14, 2019 at 10:39:27PM +0200, Max Reitz wrote: >> On 06.06.19 11:25, Klaus Birkelund Jensen wrote: >>> The device mistakenly reports that the Weighted Round Robin with Urgent >>> Priority Class arbitration mechanism is supported. >>> >>> It

Re: [Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-17 Thread Klaus Birkelund
On Fri, Jun 14, 2019 at 10:39:27PM +0200, Max Reitz wrote: > On 06.06.19 11:25, Klaus Birkelund Jensen wrote: > > The device mistakenly reports that the Weighted Round Robin with Urgent > > Priority Class arbitration mechanism is supported. > > > > It is not. > > I believe you based on the fact

Re: [Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-14 Thread Max Reitz
On 06.06.19 11:25, Klaus Birkelund Jensen wrote: > The device mistakenly reports that the Weighted Round Robin with Urgent > Priority Class arbitration mechanism is supported. > > It is not. I believe you based on the fact that there is no “weight” or “priority” anywhere in nvme.c, and that it

[Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-06 Thread Klaus Birkelund Jensen
The device mistakenly reports that the Weighted Round Robin with Urgent Priority Class arbitration mechanism is supported. It is not. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index