Re: [Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-02-07 Thread Igor Mammedov
On Wed, 6 Feb 2019 23:55:15 + Wei Yang wrote: > On Wed, Feb 06, 2019 at 12:59:49PM +0100, Igor Mammedov wrote: > >On Fri, 1 Feb 2019 09:08:37 +0800 > >Wei Yang wrote: > > > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. > >> > >> Since we have already set up a property

Re: [Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-02-06 Thread Wei Yang
On Wed, Feb 06, 2019 at 12:59:49PM +0100, Igor Mammedov wrote: >On Fri, 1 Feb 2019 09:08:37 +0800 >Wei Yang wrote: > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. >> >> Since we have already set up a property PC_DIMM_ADDR_PROP for this >> field and use this mechanism in

Re: [Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-02-06 Thread Igor Mammedov
On Fri, 1 Feb 2019 09:08:37 +0800 Wei Yang wrote: > [get|set]_addr are two counterpart to access PCDIMMDevice.addr. > > Since we have already set up a property PC_DIMM_ADDR_PROP for this > field and use this mechanism in set_addr, it would be more proper to use > the same mechanism in

[Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-01-31 Thread Wei Yang
[get|set]_addr are two counterpart to access PCDIMMDevice.addr. Since we have already set up a property PC_DIMM_ADDR_PROP for this field and use this mechanism in set_addr, it would be more proper to use the same mechanism in set_addr. This patch uses object_property_get_uint() to replace the