Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-27 Thread Andrew Jones
On Fri, Jan 27, 2017 at 02:54:20PM +, Peter Maydell wrote: > On 27 January 2017 at 14:31, Peter Maydell wrote: > > On 12 January 2017 at 11:36, Andrew Jones wrote: > >> On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: > >>> Thanks

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-27 Thread Peter Maydell
On 27 January 2017 at 14:31, Peter Maydell wrote: > On 12 January 2017 at 11:36, Andrew Jones wrote: >> On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: >>> Thanks for the patch. I haven't checked against the pflash spec yet, >>> but

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-27 Thread Peter Maydell
On 12 January 2017 at 11:36, Andrew Jones wrote: > On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: >> Thanks for the patch. I haven't checked against the pflash spec yet, >> but this looks like it's probably the right thing. >> >> The only two machines which use

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-16 Thread Dr. David Alan Gilbert
* Andrew Jones (drjo...@redhat.com) wrote: > On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: > > On 12 January 2017 at 10:35, David Engraf wrote: > > > The CFI entry for sector length must be set to sector length per device. > > > This is important for

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread David Engraf
Am 12.01.2017 um 12:36 schrieb Andrew Jones: On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: On 12 January 2017 at 10:35, David Engraf wrote: The CFI entry for sector length must be set to sector length per device. This is important for boards using

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread Andrew Jones
On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: > On 12 January 2017 at 10:35, David Engraf wrote: > > The CFI entry for sector length must be set to sector length per device. > > This is important for boards using multiple devices like the ARM Vexpress > >

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread Peter Maydell
On 12 January 2017 at 10:35, David Engraf wrote: > The CFI entry for sector length must be set to sector length per device. > This is important for boards using multiple devices like the ARM Vexpress > board (width = 4, device-width = 2). > > Linux and u-boots calculate

[Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread David Engraf
The CFI entry for sector length must be set to sector length per device. This is important for boards using multiple devices like the ARM Vexpress board (width = 4, device-width = 2). Linux and u-boots calculate the size ratio by dividing both values: size_ratio = info->portwidth /