Re: [Qemu-devel] [PATCH] ppc: Fix xsmaddmdp and friends

2019-08-21 Thread David Gibson
On Wed, Aug 21, 2019 at 10:28:41AM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > A class of instructions of the form: > op Target,A,B > which operate like: > Target = Target * A + B > have a bit set which distinguishes them from instructions that operate as: > Target = Target *

[Qemu-devel] [PATCH] ppc: Fix xsmaddmdp and friends

2019-08-21 Thread Paul A. Clarke
From: "Paul A. Clarke" A class of instructions of the form: op Target,A,B which operate like: Target = Target * A + B have a bit set which distinguishes them from instructions that operate as: Target = Target * B + A This bit is not being checked properly (using PPC_BIT macro), so all