Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Gerd Hoffmann
On 10/21/09 21:39, Glauber Costa wrote: $ rpm -ql kernel-headers | grep kvm /usr/include/asm/kvm.h /usr/include/linux/kvm.h Did you ever build this? You should improve your patch qa ... btw, it builds fine for me even without --kerneldir, just tested. and thelinux/kvm_para.h

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Glauber Costa
On Thu, Oct 22, 2009 at 10:00:37AM +0200, Gerd Hoffmann wrote: On 10/21/09 21:39, Glauber Costa wrote: $ rpm -ql kernel-headers | grep kvm /usr/include/asm/kvm.h /usr/include/linux/kvm.h Did you ever build this? You should improve your patch qa ... btw, it builds fine for me

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Gerd Hoffmann
Just defining the msrs instead of using kvm_para.h should be fine, the numbers will not change ... That's not the problem. If one removes kvm_para.h, a lot of other things will not build. For example, the capabilities list. And it has been like this for almost a year now! Without that header,

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Glauber Costa
On Thu, Oct 22, 2009 at 02:15:06PM +0200, Gerd Hoffmann wrote: Just defining the msrs instead of using kvm_para.h should be fine, the numbers will not change ... That's not the problem. If one removes kvm_para.h, a lot of other things will not build. For example, the capabilities list. And it

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Anthony Liguori
Glauber Costa wrote: That's not the problem. If one removes kvm_para.h, a lot of other things will not build. For example, the capabilities list. And it has been like this for almost a year now! Without that header, your system should have never successfully built a qemu-kvm instance. This is

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-21 Thread Gerd Hoffmann
On 10/20/09 16:04, Glauber Costa wrote: Currently, the msrs involved in setting up pvclock are not saved over migration and/or save/restore. This patch puts their value in special fields in our CPUState, and deal with them using vmstate. kvm also has to account for it, by including them in the

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote: On 10/20/09 16:04, Glauber Costa wrote: Currently, the msrs involved in setting up pvclock are not saved over migration and/or save/restore. This patch puts their value in special fields in our CPUState, and deal with them using

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 04:52:00PM +0200, Gerd Hoffmann wrote: On 10/21/09 16:32, Glauber Costa wrote: On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote: On 10/20/09 16:04, Glauber Costa wrote: Currently, the msrs involved in setting up pvclock are not saved over migration and/or

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-21 Thread Gerd Hoffmann
On 10/21/09 16:32, Glauber Costa wrote: On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote: On 10/20/09 16:04, Glauber Costa wrote: Currently, the msrs involved in setting up pvclock are not saved over migration and/or save/restore. This patch puts their value in special fields in

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 04:52:00PM +0200, Gerd Hoffmann wrote: On 10/21/09 16:32, Glauber Costa wrote: On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote: On 10/20/09 16:04, Glauber Costa wrote: Currently, the msrs involved in setting up pvclock are not saved over migration and/or

[Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-20 Thread Glauber Costa
Currently, the msrs involved in setting up pvclock are not saved over migration and/or save/restore. This patch puts their value in special fields in our CPUState, and deal with them using vmstate. kvm also has to account for it, by including them in the msr list for the ioctls. This is a