Re: [Qemu-devel] [PATCH] qdev: fix the order compat and global properties are applied

2016-12-06 Thread Cornelia Huck
On Tue, 6 Dec 2016 14:25:45 -0200 Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 04:41:12PM +0100, Greg Kurz wrote: > > The current code recursively applies global properties from child up to > > parent types. This can cause properties passed with the -global option to > > be silently overridde

Re: [Qemu-devel] [PATCH] qdev: fix the order compat and global properties are applied

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 04:41:12PM +0100, Greg Kurz wrote: > The current code recursively applies global properties from child up to > parent types. This can cause properties passed with the -global option to > be silently overridden by internal compat properties. > > This is exactly what happens

[Qemu-devel] [PATCH] qdev: fix the order compat and global properties are applied

2016-12-06 Thread Greg Kurz
The current code recursively applies global properties from child up to parent types. This can cause properties passed with the -global option to be silently overridden by internal compat properties. This is exactly what happens with virtio-*-pci drivers since commit: "9a4c0e220d8a hw/virtio-pci: