Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-21 Thread Michael S. Tsirkin
On Wed, Jun 13, 2018 at 01:40:59PM +0800, Jason Wang wrote: > > > On 2018年06月13日 12:24, Samudrala, Sridhar wrote: > > On 6/12/2018 7:38 PM, Jason Wang wrote: > > > > > > > > > On 2018年06月12日 19:54, Michael S. Tsirkin wrote: > > > > On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: >

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Jason Wang
On 2018年06月13日 12:24, Samudrala, Sridhar wrote: On 6/12/2018 7:38 PM, Jason Wang wrote: On 2018年06月12日 19:54, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Samudrala, Sridhar
On 6/12/2018 7:38 PM, Jason Wang wrote: On 2018年06月12日 19:54, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Jason Wang
On 2018年06月13日 08:20, Samudrala, Sridhar wrote: On 6/12/2018 4:54 AM, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Jason Wang
On 2018年06月12日 19:54, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Samudrala, Sridhar
On 6/12/2018 4:54 AM, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Michael S. Tsirkin
On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: > > > On 2018年06月05日 20:33, Michael S. Tsirkin wrote: > > I don't think this is sufficient. > > > > If both primary and standby devices are present, a legacy guest without > > support for the feature might see two devices with same mac

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Michael S. Tsirkin
On Mon, Jun 11, 2018 at 10:02:45PM -0700, Samudrala, Sridhar wrote: > On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote: > > On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote: > > > > > > On 2018年06月12日 01:26, Michael S. Tsirkin wrote: > > > > On Mon, May 07, 2018 at 04:09:54PM -0700,

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-11 Thread Samudrala, Sridhar
On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote: On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote: On 2018年06月12日 01:26, Michael S. Tsirkin wrote: On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-11 Thread Michael S. Tsirkin
On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote: > > > On 2018年06月12日 01:26, Michael S. Tsirkin wrote: > > On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote: > > > This feature bit can be used by hypervisor to indicate virtio_net device > > > to > > > act as a standby

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-11 Thread Jason Wang
On 2018年06月12日 01:26, Michael S. Tsirkin wrote: On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. I tested this with a small change to

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-11 Thread Michael S. Tsirkin
On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote: > This feature bit can be used by hypervisor to indicate virtio_net device to > act as a standby for another device with the same MAC address. > > I tested this with a small change to the patch to mark the STANDBY feature >

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-06 Thread Michael S. Tsirkin
On Wed, Jun 06, 2018 at 11:17:36AM -0700, Samudrala, Sridhar wrote: > On 6/4/2018 7:06 PM, Jason Wang wrote: > > > > > > On 2018年06月05日 09:41, Samudrala, Sridhar wrote: > > > Ping on this patch now that the kernel patches are accepted into > > > davem's net-next tree. > > >

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-06 Thread Samudrala, Sridhar
On 6/4/2018 7:06 PM, Jason Wang wrote: On 2018年06月05日 09:41, Samudrala, Sridhar wrote: Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can be

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Jason Wang
On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might see two devices with same mac and get confused. I think that we should only make primary visible after

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 01:20:33PM -0700, Samudrala, Sridhar wrote: > > On 6/5/2018 5:33 AM, Michael S. Tsirkin wrote: > > I don't think this is sufficient. > > Sure. This is not sufficient for a complete solution, but is Qemu the right > place > to manage primary/standby interfaces? > > I

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 5:33 AM, Michael S. Tsirkin wrote: I don't think this is sufficient. Sure. This is not sufficient for a complete solution, but is Qemu the right place to manage primary/standby interfaces? I think the other steps including plugging/unplugging the primary interface needs to

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might see two devices with same mac and get confused. I think that we should only make primary visible after guest acked the backup feature bit. And on reset or when

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-04 Thread Jason Wang
On 2018年06月05日 09:41, Samudrala, Sridhar wrote: Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-04 Thread Samudrala, Sridhar
Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with

[Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-05-07 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. I tested this with a small change to the patch to mark the STANDBY feature 'true' by default as i am using libvirt to start the VMs. Is there a way to pass