Re: [Qemu-devel] [PATCH] qemu-test: add virtio-serial test

2011-12-22 Thread Anthony Liguori
On 12/22/2011 09:46 AM, Alex Bradbury wrote: On 22 December 2011 14:23, Anthony Liguori wrote: This is a pretty simple test that just confirms that virtio-serial shows up and is writable. It also tests the alias for virtio-serial-pci. Signed-off-by: Anthony Liguori --- tests/virtio-serial.s

Re: [Qemu-devel] [PATCH] qemu-test: add virtio-serial test

2011-12-22 Thread Alex Bradbury
On 22 December 2011 15:58, Eric Blake wrote: > Shell assignments do not need quoting, since they are not subject to > argument splitting or filename expansion in the first place. You're right, that was an incorrectly chosen example. > Blindly requiring double-quoting of all shell variables and c

Re: [Qemu-devel] [PATCH] qemu-test: add virtio-serial test

2011-12-22 Thread Eric Blake
On 12/22/2011 08:46 AM, Alex Bradbury wrote: >> + >> +in_host() { >> +tmpchr=$tmpdir/chr.log > > By far the most common error likely to appear in any of these test > scripts is insufficient shell quoting causing e.g. breakages when the > scripts are run from a directory with spaces. Shell ass

Re: [Qemu-devel] [PATCH] qemu-test: add virtio-serial test

2011-12-22 Thread Alex Bradbury
On 22 December 2011 14:23, Anthony Liguori wrote: > This is a pretty simple test that just confirms that virtio-serial shows up > and > is writable.  It also tests the alias for virtio-serial-pci. > > Signed-off-by: Anthony Liguori > --- >  tests/virtio-serial.sh |   52 > ++

[Qemu-devel] [PATCH] qemu-test: add virtio-serial test

2011-12-22 Thread Anthony Liguori
This is a pretty simple test that just confirms that virtio-serial shows up and is writable. It also tests the alias for virtio-serial-pci. Signed-off-by: Anthony Liguori --- tests/virtio-serial.sh | 52 1 files changed, 52 insertions(+), 0 del