Re: [Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 14:16, Eric Blake wrote: > On 07/04/2017 07:23 AM, Fam Zheng wrote: >> Not all platforms check whether a lock is initialized before used. In >> particular Linux seems to be more permissive than OSX. >> >> Check initialization state explicitly in our code to catch such bugs >>

Re: [Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-06 Thread Fam Zheng
On Thu, 07/06 07:16, Eric Blake wrote: > On 07/04/2017 07:23 AM, Fam Zheng wrote: > > Not all platforms check whether a lock is initialized before used. In > > particular Linux seems to be more permissive than OSX. > > > > Check initialization state explicitly in our code to catch such bugs > >

Re: [Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-06 Thread Eric Blake
On 07/04/2017 07:23 AM, Fam Zheng wrote: > Not all platforms check whether a lock is initialized before used. In > particular Linux seems to be more permissive than OSX. > > Check initialization state explicitly in our code to catch such bugs > earlier. > > Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-06 Thread Stefan Hajnoczi
On Tue, Jul 04, 2017 at 08:23:25PM +0800, Fam Zheng wrote: > Not all platforms check whether a lock is initialized before used. In > particular Linux seems to be more permissive than OSX. > > Check initialization state explicitly in our code to catch such bugs > earlier. > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-04 Thread Philippe Mathieu-Daudé
On Tue, Jul 4, 2017 at 9:23 AM, Fam Zheng wrote: > Not all platforms check whether a lock is initialized before used. In > particular Linux seems to be more permissive than OSX. > > Check initialization state explicitly in our code to catch such bugs > earlier. > >

[Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-04 Thread Fam Zheng
Not all platforms check whether a lock is initialized before used. In particular Linux seems to be more permissive than OSX. Check initialization state explicitly in our code to catch such bugs earlier. Signed-off-by: Fam Zheng --- include/qemu/thread-posix.h | 4