[Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-06-05 Thread Michael Roth
From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move CloseHandle(token) to out branch. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-win32.c

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-21 Thread Yan Vugenfirer
On May 20, 2014, at 10:46 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: Quoting Luiz Capitulino (2014-05-20 14:17:42) On Mon, 19 May 2014 15:26:03 +0800 arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-21 Thread Wangrui (K)
-Original Message- From: Yan Vugenfirer [mailto:yvuge...@redhat.com] Sent: Wednesday, May 21, 2014 5:01 PM To: Michael Roth Cc: Luiz Capitulino; Wangrui (K); Gonglei (Arei); qemu-devel@nongnu.org; arm...@redhat.com Subject: Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Yan Vugenfirer
On May 19, 2014, at 10:26 AM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move CloseHandle(token) to out branch. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com ---

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Luiz Capitulino
On Mon, 19 May 2014 15:26:03 +0800 arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move CloseHandle(token) to out branch. Looks good to me. Michael, are you going to pick this one? Signed-off-by: Wang Rui

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Michael Roth
Quoting Luiz Capitulino (2014-05-20 14:17:42) On Mon, 19 May 2014 15:26:03 +0800 arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move CloseHandle(token) to out branch. Looks good to me. Michael, are you going to pick

[Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-19 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move CloseHandle(token) to out branch. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- qga/commands-win32.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-19 Thread Eric Blake
On 05/19/2014 01:26 AM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com token should be closed in all conditions. So move CloseHandle(token) to out branch. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com ---