On 09/19/12 15:41, Michael Tokarev wrote:
This cleans up two additions of almost the same code in commits
511b13e2c9 and ccc2960d654. While at it, make error paths
consistent (always use 'break' instead of 'return').
Other way around: should be 'return' not 'break'.
cheers,
Gerd
On 20.09.2012 10:41, Gerd Hoffmann wrote:
On 09/19/12 15:41, Michael Tokarev wrote:
This cleans up two additions of almost the same code in commits
511b13e2c9 and ccc2960d654. While at it, make error paths
consistent (always use 'break' instead of 'return').
Other way around: should be
On 09/20/12 08:43, Michael Tokarev wrote:
For now it is irrelevant actually, since right after the
switch we already have return, so break is now the
same as return. For future it might not be the case.
Oh, right. Patch added to spice patch queue.
thanks,
Gerd
This cleans up two additions of almost the same code in commits
511b13e2c9 and ccc2960d654. While at it, make error paths
consistent (always use 'break' instead of 'return').
Signed-off-by: Michael Tokarev m...@tls.msk.ru
Cc: Dunrong Huang riegama...@gmail.com
Cc: Alon Levy al...@redhat.com
---
