Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Eric Blake
On 12/02/2016 08:41 AM, Fam Zheng wrote: >>> +++ b/scripts/git.orderfile >>> @@ -0,0 +1,15 @@ >>> +*.txt >> >> We also have *.md. (OK, OK, we have a single docs/bitmaps.md, but maybe >> it's going to be more in the future. :-)) > > Maybe just insert 'docs/*' here? I'm not sure if it works for

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Fam Zheng
On Fri, 12/02 15:33, Max Reitz wrote: > On 02.12.2016 11:40, Laszlo Ersek wrote: > > When passed to git-diff (and to every other git command producing diffs > > and/or diffstats) with "-O" or "diff.orderFile", this list of patterns > > will place the more declarative / abstract hunks first, while

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Max Reitz
On 02.12.2016 11:40, Laszlo Ersek wrote: > When passed to git-diff (and to every other git command producing diffs > and/or diffstats) with "-O" or "diff.orderFile", this list of patterns > will place the more declarative / abstract hunks first, while changes to > imperative code / details will be

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Gerd Hoffmann
> # Apply this diff order to your git configuration with the command > # > # git config diff.orderFile scripts/git.orderfile Looks good to me. cheers, Gerd

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Laszlo Ersek
On 12/02/16 11:59, Gerd Hoffmann wrote: >> git config diff.orderFile scripts/git.orderfile > >> diff --git a/scripts/git.orderfile b/scripts/git.orderfile >> new file mode 100644 >> index ..600a2e4fc540 >> --- /dev/null >> +++ b/scripts/git.orderfile >> @@ -0,0 +1,15 @@ > > Is it

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Gerd Hoffmann
> git config diff.orderFile scripts/git.orderfile > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > new file mode 100644 > index ..600a2e4fc540 > --- /dev/null > +++ b/scripts/git.orderfile > @@ -0,0 +1,15 @@ Is it possible to have comments in here? So we can place

[Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Laszlo Ersek
When passed to git-diff (and to every other git command producing diffs and/or diffstats) with "-O" or "diff.orderFile", this list of patterns will place the more declarative / abstract hunks first, while changes to imperative code / details will be near the end of the patches. This saves on