Re: [Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread P J P
+-- On Mon, 21 Dec 2015, Paolo Bonzini wrote --+ | I can add the Cc to the commit message as well. For now it's enough to | send a message in Cc so that the qemu-stable people notice it. Okay, great! Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13

Re: [Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread Paolo Bonzini
On 21/12/2015 17:33, P J P wrote: > | Yes, it is. I've queued this patch to my for-2.6 branch. > > Okay, cool! Should I separately send it for 2.5 at qemu-stable? I can add the Cc to the commit message as well. For now it's enough to send a message in Cc so that the qemu-stable people notic

Re: [Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread P J P
+-- On Mon, 21 Dec 2015, Paolo Bonzini wrote --+ | > diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c | > index d7dc667..576f56c 100644 | > --- a/hw/scsi/megasas.c | > +++ b/hw/scsi/megasas.c | > @@ -718,7 +718,7 @@ static int megasas_ctrl_get_info(MegasasState *s, | > MegasasCmd *cmd) | > B

Re: [Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread Paolo Bonzini
On 21/12/2015 10:43, P J P wrote: > Hello, > > A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It > occurs while processing the SCSI controller's CTRL_GET_INFO command, as > the memset(2) call uses driver supplied 'cmd->iov_size' to initialise > the '&info' object. > > Plea

[Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread P J P
Hello, A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It occurs while processing the SCSI controller's CTRL_GET_INFO command, as the memset(2) call uses driver supplied 'cmd->iov_size' to initialise the '&info' object. Please see below a proposed patch to fix this issue.