Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-18 Thread Dave Hansen
On Fri, 2011-04-15 at 14:20 -0500, Anthony Liguori wrote: On 04/15/2011 02:15 PM, Dave Hansen wrote: On Fri, 2011-04-15 at 12:17 -0500, Anthony Liguori wrote: If you're in OOM and you need memory, you can't ask the host for more and wait for a response. You have to reclaim it immediately.

[Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Dave Hansen
There's a patch pending on LKML at the moment: http://lkml.org/lkml/2011/4/7/101 The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. As of now, qemu-kvm defines the bit, but doesn't set it. feature bit. Whenever the bit is set, the guest kernel must always tell

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Anthony Liguori
On 04/15/2011 09:44 AM, Dave Hansen wrote: There's a patch pending on LKML at the moment: http://lkml.org/lkml/2011/4/7/101 The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. As of now, qemu-kvm defines the bit, but doesn't set it. feature bit. Whenever the

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Dave Hansen
On Fri, 2011-04-15 at 11:21 -0500, Anthony Liguori wrote: This patch makes the tell host first logic the only case. This should make everybody happy, and reduce the amount of untested or untestable code in the kernel. It doesn't make me happy. Darn. Why would we do this in QEMU? This

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Anthony Liguori
On 04/15/2011 11:36 AM, Dave Hansen wrote: On Fri, 2011-04-15 at 11:21 -0500, Anthony Liguori wrote: This patch makes the tell host first logic the only case. This should make everybody happy, and reduce the amount of untested or untestable code in the kernel. It doesn't make me happy. Darn.

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Dave Hansen
On Fri, 2011-04-15 at 12:17 -0500, Anthony Liguori wrote: On 04/15/2011 11:36 AM, Dave Hansen wrote: Why would we do this in QEMU? This prevents the guest from doing ballooning reclaim during OOM. What the heck is ballooning reclaim? Could you elaborate a bit on how this happens? I

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-15 Thread Anthony Liguori
On 04/15/2011 02:15 PM, Dave Hansen wrote: On Fri, 2011-04-15 at 12:17 -0500, Anthony Liguori wrote: On 04/15/2011 11:36 AM, Dave Hansen wrote: Why would we do this in QEMU? This prevents the guest from doing ballooning reclaim during OOM. What the heck is ballooning reclaim? Could you