Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-16 Thread Greg Kurz
On Thu, 16 May 2019 21:46:01 +1000 David Gibson wrote: [...] > > I won't be sending a pull request for a little while yet, so if you > want to send a followup improving the messages I can fold it into the > original patch in my tree. > Done. https://patchwork.ozlabs.org/patch/1100396/ pgpfY

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-16 Thread David Gibson
On Thu, May 16, 2019 at 08:58:14AM +0200, Greg Kurz wrote: > On Thu, 16 May 2019 12:09:57 +0530 > Satheesh Rajendran wrote: > > > On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: > > > If a machine is started with ic-mode=xive but the guest only knows > > > about XICS, eg. an RHEL 7.6 g

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-15 Thread Greg Kurz
On Thu, 16 May 2019 12:09:57 +0530 Satheesh Rajendran wrote: > On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: > > If a machine is started with ic-mode=xive but the guest only knows > > about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is > > expected but a bit unfortunate sin

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-15 Thread Satheesh Rajendran
On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: > If a machine is started with ic-mode=xive but the guest only knows > about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is > expected but a bit unfortunate since the crash doesn't provide > much information for the end user to gue

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-15 Thread Cédric Le Goater
On 5/16/19 3:24 AM, David Gibson wrote: > On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: >> If a machine is started with ic-mode=xive but the guest only knows >> about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is >> expected but a bit unfortunate since the crash doesn't provi

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-15 Thread David Gibson
On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: > If a machine is started with ic-mode=xive but the guest only knows > about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is > expected but a bit unfortunate since the crash doesn't provide > much information for the end user to gue

[Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-15 Thread Greg Kurz
If a machine is started with ic-mode=xive but the guest only knows about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is expected but a bit unfortunate since the crash doesn't provide much information for the end user to guess what's happening. Detect that during CAS and exit QEMU with a p