Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-04 Thread Greg Kurz
On Tue, 4 Jul 2017 14:41:33 +0530 Bharata B Rao wrote: > On Tue, Jul 04, 2017 at 10:02:46AM +0200, Greg Kurz wrote: > > > > There is some history to this. I was doing error recovery and > > > > propagation > > > > here similarly during memory hotplug development

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-04 Thread Bharata B Rao
On Tue, Jul 04, 2017 at 10:02:46AM +0200, Greg Kurz wrote: > > > There is some history to this. I was doing error recovery and propagation > > > here similarly during memory hotplug development phase until Igor > > > suggested that we shoudn't try to recover after we have done guest > > > visible

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-04 Thread Greg Kurz
On Tue, 4 Jul 2017 09:20:50 +0530 Bharata B Rao wrote: > On Tue, Jul 04, 2017 at 09:01:43AM +0530, Bharata B Rao wrote: > > On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > > > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > > >

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Bharata B Rao
On Tue, Jul 04, 2017 at 09:01:43AM +0530, Bharata B Rao wrote: > On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > > Let's propagate the error instead, like it is done everywhere else > > where spapr_drc_attach() is

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Bharata B Rao
On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > Let's propagate the error instead, like it is done everywhere else > where spapr_drc_attach() is called. > > Signed-off-by: Greg Kurz > --- >

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Greg Kurz
On Mon, 3 Jul 2017 15:43:26 +0200 Igor Mammedov wrote: > On Mon, 03 Jul 2017 14:21:31 +0200 > Greg Kurz wrote: > > > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > > Let's propagate the error instead, like it is done everywhere else >

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Igor Mammedov
On Mon, 03 Jul 2017 14:21:31 +0200 Greg Kurz wrote: > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > Let's propagate the error instead, like it is done everywhere else > where spapr_drc_attach() is called. > > Signed-off-by: Greg Kurz >

[Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Greg Kurz
QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. Let's propagate the error instead, like it is done everywhere else where spapr_drc_attach() is called. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c | 10 -- 1 file changed, 8 insertions(+), 2