Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-21 Thread Andreas Färber
Am 20.09.2012 19:03, schrieb Stefan Weil: Am 05.09.2012 19:45, schrieb Stefan Weil: Am 05.09.2012 19:15, schrieb Stefan Weil: AFAIK, binutils moved to GPL 3. Therefore I don't expect that QEMU will update to upstream in the next years. We'll have to maintain the code which we have. Try

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-20 Thread Stefan Weil
Am 05.09.2012 19:45, schrieb Stefan Weil: Am 05.09.2012 19:15, schrieb Stefan Weil: AFAIK, binutils moved to GPL 3. Therefore I don't expect that QEMU will update to upstream in the next years. We'll have to maintain the code which we have. Try git log *-dis.c or gitk *-dis.c: there are

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Andreas Färber
Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil s...@weilnetz.de --- Coding style was not fixed. - sw sparc-dis.c |3 +-- 1 file changed, 1

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Hajnoczi
On Wed, Sep 5, 2012 at 4:51 PM, Andreas Färber afaer...@suse.de wrote: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil s...@weilnetz.de --- Coding style

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 18:55, schrieb Stefan Hajnoczi: On Wed, Sep 5, 2012 at 4:51 PM, Andreas Färberafaer...@suse.de wrote: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by:

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 19:15, schrieb Stefan Weil: AFAIK, binutils moved to GPL 3. Therefore I don't expect that QEMU will update to upstream in the next years. We'll have to maintain the code which we have. Try git log *-dis.c or gitk *-dis.c: there are already lots of more trivial changes which got

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 17:51, schrieb Andreas Färber: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weils...@weilnetz.de --- Coding style was not fixed. - sw

[Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-03 Thread Stefan Weil
Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil s...@weilnetz.de --- Coding style was not fixed. - sw sparc-dis.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sparc-dis.c