Re: [Qemu-devel] [PATCH] sun4u: fix assert when adding NICs which aren't the in-built model

2017-10-18 Thread Artyom Tarasenko
On Sun, Oct 15, 2017 at 11:21 AM, Mark Cave-Ayland wrote: > Commit 8d93297 introduced a bug whereby non-inbuilt NICs are realized before > setting the default MAC address causing an assert. Switch NIC creation > over from pci_create_simple() to pci_create() which

[Qemu-devel] [PATCH] sun4u: fix assert when adding NICs which aren't the in-built model

2017-10-15 Thread Mark Cave-Ayland
Commit 8d93297 introduced a bug whereby non-inbuilt NICs are realized before setting the default MAC address causing an assert. Switch NIC creation over from pci_create_simple() to pci_create() which works exactly the same except omitting the realize as originally intended. Signed-off-by: Mark