Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

2018-06-06 Thread Paolo Bonzini
On 06/06/2018 11:13, Ricardo Ribalda Delgado wrote: > Hi Richard, > > I cannot find this patch on qemu master branch. Do you need any help > to get this done? I queued it now, thanks for the reminder! Paolo > Thanks! > On Wed, Jul 12, 2017 at 8:45 PM Richard Henderson wrote: >> >> The impleme

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

2018-06-06 Thread Ricardo Ribalda Delgado
Hi Richard, I cannot find this patch on qemu master branch. Do you need any help to get this done? Thanks! On Wed, Jul 12, 2017 at 8:45 PM Richard Henderson wrote: > > The implementation of these two instructions was swapped. > At the same time, unify the setup of eflags for the insn group. > >

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

2017-07-12 Thread Ricardo Ribalda Delgado
This seems to work fine with the example. But my app still throughs sigsegv :( diff --git a/target/i386/translate.c b/target/i386/translate.c index 2c64d2b71ec4..564b9c6057c2 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -4033,32 +4033,23 @@ static void gen_sse(CPUX86State

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

2017-07-12 Thread Richard Henderson
On 07/12/2017 08:58 AM, Ricardo Ribalda Delgado wrote: Hi Richard Thanks again!, When I apply this patch I get the following error: /tmp/qemu/tcg/tcg.c:2042: tcg fatal error Bah. I misremembered that OR_TMP1 is unusable in this context. r~

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

2017-07-12 Thread Ricardo Ribalda Delgado
Hi Richard Thanks again!, When I apply this patch I get the following error: /tmp/qemu/tcg/tcg.c:2042: tcg fatal error Regards! On Wed, Jul 12, 2017 at 8:45 PM, Richard Henderson wrote: > The implementation of these two instructions was swapped. > At the same time, unify the setup of eflags fo

[Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

2017-07-12 Thread Richard Henderson
The implementation of these two instructions was swapped. At the same time, unify the setup of eflags for the insn group. Reported-by: Ricardo Ribalda Delgado Signed-off-by: Richard Henderson --- target/i386/translate.c | 25 - 1 file changed, 8 insertions(+), 17 deletio