Re: [Qemu-devel] [PATCH] target/riscv: Remove unused include of riscv_htif.h for virt board

2019-04-25 Thread Palmer Dabbelt
On Wed, 10 Apr 2019 09:29:11 PDT (-0700), finte...@gmail.com wrote: Unless I'm missing something, the virt board doesn't support HTIF and should not be including this header. Jonathan Signed-off-by: Jonathan Behrens --- hw/riscv/virt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ris

Re: [Qemu-devel] [PATCH] target/riscv: Remove unused include of riscv_htif.h for virt board

2019-04-10 Thread Alistair Francis
On Wed, Apr 10, 2019 at 9:30 AM Jonathan Behrens wrote: > > Unless I'm missing something, the virt board doesn't support HTIF and > should not be including this header. Thanks for the patch! You aren't missing anything, it can be removed. > > Jonathan Can you send a v2 without the uncertainty

[Qemu-devel] [PATCH] target/riscv: Remove unused include of riscv_htif.h for virt board

2019-04-10 Thread Jonathan Behrens
Unless I'm missing something, the virt board doesn't support HTIF and should not be including this header. Jonathan Signed-off-by: Jonathan Behrens --- hw/riscv/virt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index fc4c6b306e..3526463034 100644 --- a/