Re: [Qemu-devel] [PATCH] target/s390x: Remove leading underscores from #defines

2018-03-05 Thread Cornelia Huck
On Mon, 5 Mar 2018 06:16:58 +0100 Thomas Huth wrote: > We should not use leading underscores followed by a capital letter > in #defines since such identifiers are reserved by the C standard. > > For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also > added

Re: [Qemu-devel] [PATCH] target/s390x: Remove leading underscores from #defines

2018-03-05 Thread David Hildenbrand
On 05.03.2018 06:16, Thomas Huth wrote: > We should not use leading underscores followed by a capital letter > in #defines since such identifiers are reserved by the C standard. > Didn't know about that but seems to be true. > For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also

[Qemu-devel] [PATCH] target/s390x: Remove leading underscores from #defines

2018-03-04 Thread Thomas Huth
We should not use leading underscores followed by a capital letter in #defines since such identifiers are reserved by the C standard. For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also added parentheses around the value to silence an error message from checkpatch.pl.