Re: [Qemu-devel] [PATCH] target-arm: Fix UNDEF cases in Thumb load/store

2011-03-22 Thread Aurelien Jarno
On Thu, Mar 10, 2011 at 04:48:49PM +, Peter Maydell wrote: Decode of Thumb load/store was merging together the cases of 'bit 11==0' (reg+reg LSL imm) and 'bit 11==1' (reg+imm). This happens to work for valid instruction patterns but meant that we would not UNDEF for the cases the

[Qemu-devel] [PATCH] target-arm: Fix UNDEF cases in Thumb load/store

2011-03-10 Thread Peter Maydell
Decode of Thumb load/store was merging together the cases of 'bit 11==0' (reg+reg LSL imm) and 'bit 11==1' (reg+imm). This happens to work for valid instruction patterns but meant that we would not UNDEF for the cases the architecture mandates that we must. Make the decode actually look at bit 11