Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Laurent Desnogues
On Thu, Dec 3, 2015 at 3:36 PM, Peter Maydell wrote: > On 30 November 2015 at 22:23, Andrew Baumann > wrote: >> Qemu does not generally perform alignment checks. However, the ARM ARM >> requires implementation of alignment exceptions for a

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Peter Maydell
On 30 November 2015 at 22:23, Andrew Baumann wrote: > Qemu does not generally perform alignment checks. However, the ARM ARM > requires implementation of alignment exceptions for a number of cases > including LDREX, and Windows-on-ARM relies on this. > > This change

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 14:58, Laurent Desnogues wrote: > On Thu, Dec 3, 2015 at 3:36 PM, Peter Maydell > wrote: >> On 30 November 2015 at 22:23, Andrew Baumann >> wrote: >>> Qemu does not generally perform

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Richard Henderson
On 12/03/2015 07:08 AM, Peter Maydell wrote: > On 3 December 2015 at 14:58, Laurent Desnogues > wrote: >> On Thu, Dec 3, 2015 at 3:36 PM, Peter Maydell >> wrote: >>> On 30 November 2015 at 22:23, Andrew Baumann >>>

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 21:21, Richard Henderson wrote: > On 12/03/2015 07:08 AM, Peter Maydell wrote: >> On 3 December 2015 at 14:58, Laurent Desnogues >> wrote: >>> After quickly looking at the code in softmmu_template.h, I wonder if >>> MO_ALIGN

[Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-11-30 Thread Andrew Baumann
Qemu does not generally perform alignment checks. However, the ARM ARM requires implementation of alignment exceptions for a number of cases including LDREX, and Windows-on-ARM relies on this. This change adds a helper function to raise an alignment exception (data abort), a framework for