Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-29 Thread Eduardo Habkost
(CCing libvirt people) On Tue, May 28, 2013 at 06:48:52PM +0200, Andreas Färber wrote: > Am 28.05.2013 18:46, schrieb Paolo Bonzini: > > Il 28/05/2013 18:34, Bandan Das ha scritto: > >> Eduardo Habkost writes: > >> > >>> On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: > Il 27/

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-28 Thread Andreas Färber
Am 28.05.2013 18:46, schrieb Paolo Bonzini: > Il 28/05/2013 18:34, Bandan Das ha scritto: >> Eduardo Habkost writes: >> >>> On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: Il 27/05/2013 14:09, Eduardo Habkost ha scritto: > On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bon

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-28 Thread Paolo Bonzini
Il 28/05/2013 18:34, Bandan Das ha scritto: > Eduardo Habkost writes: > >> On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: >>> Il 27/05/2013 14:09, Eduardo Habkost ha scritto: On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote: > Il 25/05/2013 03:21, Bandan Das

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-28 Thread Bandan Das
Eduardo Habkost writes: > On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: >> Il 27/05/2013 14:09, Eduardo Habkost ha scritto: >> > On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote: >> >> Il 25/05/2013 03:21, Bandan Das ha scritto: >> >>> There is one user-visible effec

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-27 Thread Eduardo Habkost
On Mon, May 27, 2013 at 03:14:25PM +0200, Paolo Bonzini wrote: > Il 27/05/2013 15:07, Eduardo Habkost ha scritto: > >> Changing TCG to KVM should not change hardware > >> > if you use "-cpu ...,enforce", so it is right that it fails when > >> > starting with KVM. > >> > > > Changing between KVM an

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-27 Thread Paolo Bonzini
Il 27/05/2013 15:07, Eduardo Habkost ha scritto: >> Changing TCG to KVM should not change hardware >> > if you use "-cpu ...,enforce", so it is right that it fails when >> > starting with KVM. >> > > Changing between KVM and TCG _does_ change hardware, today (with or > without check/enforce). All

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-27 Thread Eduardo Habkost
On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: > Il 27/05/2013 14:09, Eduardo Habkost ha scritto: > > On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote: > >> Il 25/05/2013 03:21, Bandan Das ha scritto: > >>> There is one user-visible effect: "-cpu ...,enforce" will stop

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-27 Thread Paolo Bonzini
Il 27/05/2013 14:09, Eduardo Habkost ha scritto: > On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote: >> Il 25/05/2013 03:21, Bandan Das ha scritto: >>> There is one user-visible effect: "-cpu ...,enforce" will stop failing >>> because of missing KVM support for CPUID_EXT_MONITOR. But t

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-27 Thread Eduardo Habkost
On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote: > Il 25/05/2013 03:21, Bandan Das ha scritto: > > There is one user-visible effect: "-cpu ...,enforce" will stop failing > > because of missing KVM support for CPUID_EXT_MONITOR. But that's exactly > > the point: there's no point in hav

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-24 Thread Paolo Bonzini
Il 25/05/2013 03:21, Bandan Das ha scritto: > There is one user-visible effect: "-cpu ...,enforce" will stop failing > because of missing KVM support for CPUID_EXT_MONITOR. But that's exactly > the point: there's no point in having CPU model definitions that would > never work as-is with neither TC

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-24 Thread Bandan Das
Forwarding message by Eduardo. I had misspelled nongnu.org in my first attempt! The spaces/tab comment by Eduardo has been fixed. Eduardo Habkost writes: > > By default, CPUID_EXT_MONITOR is enabled for some cpu models > such as Opteron_G3. Disable it if kvm_enabled() is true since > monitor/

[Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-24 Thread Bandan Das
By default, CPUID_EXT_MONITOR is enabled for some cpu models such as Opteron_G3. Disable it if kvm_enabled() is true since monitor/mwait aren't supported by KVM yet. Signed-off-by: Bandan Das --- There is no user visible side-effect to this behavior, the aim is to clean up the default flags