Re: [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

Hi - Original Message - > On 08/02/2017 05:07 PM, Marc-André Lureau wrote: > > >> > >> Rather than leave this untested time-bomb in place, rip it out. > > >> > >> Signed-off-by: Eric Blake > > > > I think it used to work in a vm (as qemu-ga user), but I don't mind

Re: [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

On 08/02/2017 05:07 PM, Marc-André Lureau wrote: >> >> Rather than leave this untested time-bomb in place, rip it out. >> >> Signed-off-by: Eric Blake > > I think it used to work in a vm (as qemu-ga user), but I don't mind to revert > it if we need it back: > >

Re: [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

- Original Message - > Back when the test was introduced, in commit 62c39b307, the > test was set up to run qemu-ga directly on the host performing > the test, and defaults to limiting itself to safe commands. At > the time, it was envisioned that setting QGA_TEST_SIDE_EFFECTING > in

[Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

Back when the test was introduced, in commit 62c39b307, the test was set up to run qemu-ga directly on the host performing the test, and defaults to limiting itself to safe commands. At the time, it was envisioned that setting QGA_TEST_SIDE_EFFECTING in the environment could cover a few more