Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-02 Thread Thomas Huth
On 2018-10-30 00:18, Philippe Mathieu-Daudé wrote: > Fix the extraneous extra blank lines in the test output when running with V=1. > > Before: > > TEST: tests/bios-tables-test... (pid=25678) > /i386/acpi/piix4: > Looking for expected file 'tests/acpi-test-data/pc/DSDT' > > Usi

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-01 Thread Eric Blake
On 10/29/18 7:18 PM, Philippe Mathieu-Daudé wrote: Fix the extraneous extra blank lines in the test output when running with V=1. +++ b/tests/bios-tables-test.c @@ -371,6 +371,9 @@ static GArray *load_expected_aml(test_data *data) gboolean ret; GArray *exp_tables = g_array_new(

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-01 Thread Peter Maydell
On 1 November 2018 at 14:26, Eric Blake wrote: > Umm, this prints a blank line even if I run 'make check V=0' - do we support > V=0 as a way to disable verbosity Empirically, we do not. Our rules.make defines quiet-command = $(if $(V),$1,$(if $(2),@printf " %-7s %s\n" $2 $3 && $1, @$1)) which w

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-01 Thread Igor Mammedov
On Tue, 30 Oct 2018 01:18:40 +0100 Philippe Mathieu-Daudé wrote: > Fix the extraneous extra blank lines in the test output when running with V=1. > > Before: > > TEST: tests/bios-tables-test... (pid=25678) > /i386/acpi/piix4: > Looking for expected file 'tests/acpi-test-data/pc/DS

[Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-10-29 Thread Philippe Mathieu-Daudé
Fix the extraneous extra blank lines in the test output when running with V=1. Before: TEST: tests/bios-tables-test... (pid=25678) /i386/acpi/piix4: Looking for expected file 'tests/acpi-test-data/pc/DSDT' Using expected file 'tests/acpi-test-data/pc/DSDT' Looking for expe