Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-23 Thread Eric Blake
On 03/23/2016 06:17 PM, Eric Blake wrote: > On 03/20/2016 08:43 AM, Veronia wrote: >> >> Signed-off-by: Veronia Bahaa > > Space before <. 'git commit -s' (or 'git commit --amend -s' on an > existing commit) will space things correctly if your ~/.gitconfig is >

Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-23 Thread Eric Blake
On 03/20/2016 08:43 AM, Veronia wrote: > move declarations out of qemu-common.h for functions declared in > utils/ files: e.g. include/qemu/path.h for utils/path.c. > move inline functions out of qemu-common.h and into new files (e.g. > include/qemu/bcd.h) > > Signed-off-by: Veronia

Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-21 Thread Paolo Bonzini
There are only two issues with the patch, which I fixed before queuing it for my next pull request. On 20/03/2016 18:16, veroniaba...@gmail.com wrote: > -/* path.c */ > -void init_paths(const char *prefix); > -const char *path(const char *pathname); The first is that only the above two lines

[Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-20 Thread veroniabahaa
From: Veronia Move declarations out of qemu-common.h for functions declared in utils/ files: e.g. include/qemu/path.h for utils/path.c. Move inline functions out of qemu-common.h and into new files (e.g. include/qemu/bcd.h) Signed-off-by: Veronia

[Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-20 Thread Veronia
move declarations out of qemu-common.h for functions declared in utils/ files: e.g. include/qemu/path.h for utils/path.c. move inline functions out of qemu-common.h and into new files (e.g. include/qemu/bcd.h) Signed-off-by: Veronia Bahaa --- arch_init.c