Re: [Qemu-devel] [PATCH] virtio: zero vq->inuse in virtio_reset()

2016-09-08 Thread Cornelia Huck
On Wed, 7 Sep 2016 11:51:25 -0400 Stefan Hajnoczi wrote: > vq->inuse must be zeroed upon device reset like most other virtqueue > fields. > > In theory, virtio_reset() just needs assert(vq->inuse == 0) since > devices must clean up in-flight requests during reset (requests

Re: [Qemu-devel] [PATCH] virtio: zero vq->inuse in virtio_reset()

2016-09-08 Thread Ladi Prosek
On Wed, Sep 7, 2016 at 5:54 PM, Stefan Hajnoczi wrote: > On Wed, Sep 7, 2016 at 11:51 AM, Stefan Hajnoczi wrote: >> vq->inuse must be zeroed upon device reset like most other virtqueue >> fields. >> >> In theory, virtio_reset() just needs assert(vq->inuse

Re: [Qemu-devel] [PATCH] virtio: zero vq->inuse in virtio_reset()

2016-09-07 Thread Stefan Hajnoczi
On Wed, Sep 7, 2016 at 11:51 AM, Stefan Hajnoczi wrote: > vq->inuse must be zeroed upon device reset like most other virtqueue > fields. > > In theory, virtio_reset() just needs assert(vq->inuse == 0) since > devices must clean up in-flight requests during reset (requests

[Qemu-devel] [PATCH] virtio: zero vq->inuse in virtio_reset()

2016-09-07 Thread Stefan Hajnoczi
vq->inuse must be zeroed upon device reset like most other virtqueue fields. In theory, virtio_reset() just needs assert(vq->inuse == 0) since devices must clean up in-flight requests during reset (requests cannot not be leaked!). In practice, it is difficult to achieve vq->inuse == 0 across