[Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms

2016-01-06 Thread Michal Privoznik
If you have an empty IDE cdrom we will start just fine: -drive if=none,id=drive-ide0-0-0,readonly=on -device ide-cd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 However, that's not the case with virtio disk: -drive if=none,media=cdrom,id=drive-virtio-disk1,readonly=on -device

Re: [Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms

2016-01-06 Thread P J P
+-- On Wed, 6 Jan 2016, Michal Privoznik wrote --+ | } | -if (!blk_is_inserted(conf->conf.blk)) { | + | +dinfo = blk_legacy_dinfo(conf->conf.blk); | +if (!((dinfo && dinfo->media_cd) || | + blk_is_inserted(conf->conf.blk))) { | error_setg(errp, "Device needs

Re: [Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms

2016-01-06 Thread Stefan Hajnoczi
On Wed, Jan 06, 2016 at 11:35:43AM +0100, Michal Privoznik wrote: > If you have an empty IDE cdrom we will start just fine: > > -drive if=none,id=drive-ide0-0-0,readonly=on > -device ide-cd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 > > However, that's not the case with virtio disk: > >