Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Tue, Nov 13, 2018 at 10:21:07AM +0200, Yuri Benditovich wrote: > > > On Mon, Nov 12, 2018 at 10:53 PM Michael S. Tsirkin wrote: > > On Mon, Nov 12, 2018 at 01:31:36PM +0200, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > >

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Mon, Nov 12, 2018 at 10:53 PM Michael S. Tsirkin wrote: > On Mon, Nov 12, 2018 at 01:31:36PM +0200, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > > > > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

Looks good, I can't recall the status of last version well but I remember Jason gave some comments about sanity check are quiet essential, have you addressed them? Reviewed by: Wei Xu On Fri, Nov 09, 2018 at 04:58:27PM +0200, Yuri Benditovich wrote: > This commit adds implementation of RX packet

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Mon, Nov 12, 2018 at 01:31:36PM +0200, Yuri Benditovich wrote: > > > On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: > > > > On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin > > wrote: > >

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: > > > > On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin > > wrote: > > > > On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > > > @@ -66,

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On 2018/11/12 下午4:57, Yuri Benditovich wrote: On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin > wrote: On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: >     > @@ -66,12 +143,16 @@ typedef struct VirtIONet { >     >      VirtIONetQueue

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin wrote: > On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > > @@ -66,12 +143,16 @@ typedef struct VirtIONet { > > > VirtIONetQueue *vqs; > > > VirtQueue *ctrl_vq; > > > NICState *nic; > > > +

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > @@ -66,12 +143,16 @@ typedef struct VirtIONet { > >      VirtIONetQueue *vqs; > >      VirtQueue *ctrl_vq; > >      NICState *nic; > > +    QTAILQ_HEAD(, NetRscChain) rsc_chains; > > what exactly happens

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Fri, Nov 9, 2018 at 8:11 PM Michael S. Tsirkin wrote: > Looks good to me. Some comments below > > On Fri, Nov 09, 2018 at 04:58:27PM +0200, Yuri Benditovich wrote: > > This commit adds implementation of RX packets > > coalescing, compatible with requirements of Windows > > Hardware compatibili

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

Looks good to me. Some comments below On Fri, Nov 09, 2018 at 04:58:27PM +0200, Yuri Benditovich wrote: > This commit adds implementation of RX packets > coalescing, compatible with requirements of Windows > Hardware compatibility kit. > > The device enables feature VIRTIO_NET_F_RSC_EXT in > host

[Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

This commit adds implementation of RX packets coalescing, compatible with requirements of Windows Hardware compatibility kit. The device enables feature VIRTIO_NET_F_RSC_EXT in host features if it supports extended RSC functionality as defined in the specification. This feature requires at least o