Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: The help output is going to change dramatically for 0.13. We've spent too long waiting for a perfect solution to capabilities handling and the end loser is the direct consumer of

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote: Assuming version X (according to query-version) supports no less than upstream version X sounds fair. If a command line option has a corresponding QMP command, probing QMP for the feature suffices. For instance,

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote: Assuming version X (according to query-version) supports no less than upstream version X sounds fair. If a command line option has a corresponding QMP command, probing QMP

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 26/07/2012 16:10, Anthony Liguori ha scritto: Yup. You could do: qom-list-types implements=TYPE_DEVICE And that will give you the various types. We'll need to add a: device-list-properties typename=FOO I've got a patch locally for

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Paolo Bonzini
Il 26/07/2012 16:10, Anthony Liguori ha scritto: Yup. You could do: qom-list-types implements=TYPE_DEVICE And that will give you the various types. We'll need to add a: device-list-properties typename=FOO I've got a patch locally for that that I'm testing right now. Paolo and I

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote: Daniel P. Berrange berra...@redhat.com writes: The above would take care of probably 50% of the current libvirt capabilities probing, including a portion of the -help stuff. Then there is all the rest of the crap we detect

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-27 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote: Daniel P. Berrange berra...@redhat.com writes: The above would take care of probably 50% of the current libvirt capabilities probing, including a portion of the -help stuff.

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-26 Thread Daniel P. Berrange
On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: The help output is going to change dramatically for 0.13. We've spent too long waiting for a perfect solution to capabilities handling and the end loser is the direct consumer of QEMU because the help output is awful. I will

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-26 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 01:47:23PM +0100, Daniel P. Berrange wrote: On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: The help output is going to change dramatically for 0.13. We've spent too long waiting for a perfect solution to capabilities handling and the end loser is

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-26 Thread Anthony Liguori
Daniel P. Berrange berra...@redhat.com writes: On Thu, Jul 26, 2012 at 01:47:23PM +0100, Daniel P. Berrange wrote: On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: The help output is going to change dramatically for 0.13. We've spent too long waiting for a perfect

[Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-25 Thread Anthony Liguori
The help output is going to change dramatically for 0.13. We've spent too long waiting for a perfect solution to capabilities handling and the end loser is the direct consumer of QEMU because the help output is awful. I will not apply any patches that change help output until 0.13 development

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-25 Thread Eric Blake
[adding libvirt] On 07/25/2012 01:47 PM, Anthony Liguori wrote: The help output is going to change dramatically for 0.13. We've spent too long 0.13? How long have you been sitting on this commit? :) waiting for a perfect solution to capabilities handling and the end loser is the direct

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-25 Thread Anthony Liguori
Eric Blake ebl...@redhat.com writes: [adding libvirt] On 07/25/2012 01:47 PM, Anthony Liguori wrote: The help output is going to change dramatically for 0.13. We've spent too long 0.13? How long have you been sitting on this commit? :) Yeah, I meant 1.3 :-) It's been a long day...