Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-05 Thread Christian Borntraeger
Am 05.03.2015 um 01:40 schrieb Eric Blake: > On 03/03/2015 10:32 AM, Paolo Bonzini wrote: >> >> >> On 03/03/2015 18:19, Oliver Francke wrote: >>> >>> #0 __GI_exit (status=1) at exit.c:104 >>> #1 0x5575cf15 in os_daemonize () at os-posix.c:227 >>> #2 0x55773f2e in main (argc=50, a

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-04 Thread Eric Blake
On 03/03/2015 10:32 AM, Paolo Bonzini wrote: > > > On 03/03/2015 18:19, Oliver Francke wrote: >> >> #0 __GI_exit (status=1) at exit.c:104 >> #1 0x5575cf15 in os_daemonize () at os-posix.c:227 >> #2 0x55773f2e in main (argc=50, argv=0x7fffe0d8, >> envp=0x7fffe270) at vl.

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-04 Thread Christian Borntraeger
Am 03.03.2015 um 18:32 schrieb Paolo Bonzini: > > > On 03/03/2015 18:19, Oliver Francke wrote: >> >> #0 __GI_exit (status=1) at exit.c:104 >> #1 0x5575cf15 in os_daemonize () at os-posix.c:227 >> #2 0x55773f2e in main (argc=50, argv=0x7fffe0d8, >> envp=0x7fffe270) at vl

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Oliver Francke
Hi, > Am 03.03.2015 um 18:32 schrieb Paolo Bonzini : > > > > On 03/03/2015 18:19, Oliver Francke wrote: >> >> #0 __GI_exit (status=1) at exit.c:104 >> #1 0x5575cf15 in os_daemonize () at os-posix.c:227 >> #2 0x55773f2e in main (argc=50, argv=0x7fffe0d8, >> envp=0x7ff

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Paolo Bonzini
On 03/03/2015 18:19, Oliver Francke wrote: > > #0 __GI_exit (status=1) at exit.c:104 > #1 0x5575cf15 in os_daemonize () at os-posix.c:227 > #2 0x55773f2e in main (argc=50, argv=0x7fffe0d8, > envp=0x7fffe270) at vl.c:3770 > > compiled with "--enable-debug" and in gdb "

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Paolo Bonzini
On 03/03/2015 17:03, Oliver Francke wrote: > > /usr/local/qemu-2.3.0/bin/qemu-system-x86_64 -daemonize -usbdevice > tablet -enable-kvm -pidfile /var/run/qemu-server/3371.pid -monitor > unix:/var/run/qemu-server/3371.mon,server,nowait -vnc > unix:/var/run/qemu-server/3371.vnc,password -qmp > unix

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Oliver Francke
First bt try below... On 03/03/2015 05:51 PM, Paolo Bonzini wrote: On 03/03/2015 17:03, Oliver Francke wrote: /usr/local/qemu-2.3.0/bin/qemu-system-x86_64 -daemonize -usbdevice tablet -enable-kvm -pidfile /var/run/qemu-server/3371.pid -monitor unix:/var/run/qemu-server/3371.mon,server,nowait -

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Oliver Francke
Hi all, just brief, this small one breaks my qemu-system-x86_64 with: qemu: qemu_cond_wait: Operation not permitted My most complete qemu-starter: /usr/local/qemu-2.3.0/bin/qemu-system-x86_64 -daemonize -usbdevice tablet -enable-kvm -pidfile /var/run/qemu-server/3371.pid -monitor unix:/v

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Peter Maydell
On 3 March 2015 at 19:36, Paolo Bonzini wrote: > If the iothread lock isn't taken by the main thread, the RCU callbacks > might run concurrently with the main thread. QEMU's not ready for that. > > Signed-off-by: Paolo Bonzini Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Gonglei
On 2015/3/3 18:36, Paolo Bonzini wrote: > If the iothread lock isn't taken by the main thread, the RCU callbacks > might run concurrently with the main thread. QEMU's not ready for that. > > Signed-off-by: Paolo Bonzini > --- > vl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Christian Borntraeger
Am 03.03.2015 um 11:36 schrieb Paolo Bonzini: > If the iothread lock isn't taken by the main thread, the RCU callbacks > might run concurrently with the main thread. QEMU's not ready for that. > > Signed-off-by: Paolo Bonzini Tested-by: Christian Borntraeger > --- > vl.c | 6 +++--- > 1 file

[Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Paolo Bonzini
If the iothread lock isn't taken by the main thread, the RCU callbacks might run concurrently with the main thread. QEMU's not ready for that. Signed-off-by: Paolo Bonzini --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 09693f5..d743727 10064