Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Paolo Bonzini
Il 21/11/2013 15:37, Peter Lieven ha scritto: -max_cpus = qemu_opt_get_number(opts, maxcpus, 0); +if (cpus != sockets * cores * threads) { +fprintf(stderr, Illegal CPU layout: %d cpus with %d sockets, + %d cores per socket and %d threads

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Peter Lieven
On 22.11.2013 11:16, Paolo Bonzini wrote: Il 21/11/2013 15:37, Peter Lieven ha scritto: -max_cpus = qemu_opt_get_number(opts, maxcpus, 0); +if (cpus != sockets * cores * threads) { +fprintf(stderr, Illegal CPU layout: %d cpus with %d sockets, +

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Paolo Bonzini
Il 22/11/2013 12:13, Peter Lieven ha scritto: I see where you come from, but I think the potential for this patch to break some working configuration (for some definition of working) is too high. Can you split out the fixes to the fill in the blanks logic? I can, but the number of sockets

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Andreas Färber
Am 22.11.2013 12:20, schrieb Paolo Bonzini: Il 22/11/2013 12:13, Peter Lieven ha scritto: I see where you come from, but I think the potential for this patch to break some working configuration (for some definition of working) is too high. Can you split out the fixes to the fill in the blanks

[Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-21 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- vl.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/vl.c b/vl.c index 8d5d874..dc0b41a 100644 --- a/vl.c +++ b/vl.c @@ -1385,35 +1385,41 @@ static QemuOptsList qemu_smp_opts = { static void