Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On 08/08/2017 14:53, Stefan Hajnoczi wrote: > On Fri, Aug 04, 2017 at 01:46:17PM +0200, Paolo Bonzini wrote: >> On 04/08/2017 11:58, Stefan Hajnoczi wrote: the root cause of this bug is related to this as well: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

Am 08.08.2017 um 14:53 hat Stefan Hajnoczi geschrieben: > On Fri, Aug 04, 2017 at 01:46:17PM +0200, Paolo Bonzini wrote: > > On 04/08/2017 11:58, Stefan Hajnoczi wrote: > > >> the root cause of this bug is related to this as well: > > >>

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On Fri, Aug 04, 2017 at 01:46:17PM +0200, Paolo Bonzini wrote: > On 04/08/2017 11:58, Stefan Hajnoczi wrote: > >> the root cause of this bug is related to this as well: > >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html > >> > >> From commit 99723548 we started assuming

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On 08/08/2017 13:56, Kevin Wolf wrote: > Am 08.08.2017 um 13:04 hat Paolo Bonzini geschrieben: >> On 08/08/2017 12:02, Kevin Wolf wrote: >>> Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: On 04/08/2017 11:58, Stefan Hajnoczi wrote: >> the root cause of this bug is related to this

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

Am 08.08.2017 um 13:04 hat Paolo Bonzini geschrieben: > On 08/08/2017 12:02, Kevin Wolf wrote: > > Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: > >> On 04/08/2017 11:58, Stefan Hajnoczi wrote: > the root cause of this bug is related to this as well: >

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On 08/08/2017 12:02, Kevin Wolf wrote: > Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: >> On 04/08/2017 11:58, Stefan Hajnoczi wrote: the root cause of this bug is related to this as well: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html From commit

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: > On 04/08/2017 11:58, Stefan Hajnoczi wrote: > >> the root cause of this bug is related to this as well: > >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html > >> > >> From commit 99723548 we started assuming (incorrectly?)

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On 04/08/2017 11:58, Stefan Hajnoczi wrote: >> the root cause of this bug is related to this as well: >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html >> >> From commit 99723548 we started assuming (incorrectly?) that blk_ >> functions always WILL have an attached BDS, but

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On Mon, Jul 17, 2017 at 5:43 PM, John Snow wrote: > On 07/17/2017 06:26 AM, Dr. David Alan Gilbert wrote: >> * Stefan Hajnoczi (stefa...@gmail.com) wrote: >>> On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) >>> wrote: From: "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

rg, pbonz...@redhat.com, js...@redhat.com >> Sent: Thursday, August 3, 2017 6:45:17 PM >> Subject: Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block >> devices >> >> * Alberto Garcia (be...@igalia.com) wrote: >> > On Thu, Jul 13, 2017

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

- Original Message - > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > To: "Alberto Garcia" <be...@igalia.com> > Cc: qemu-devel@nongnu.org, pbonz...@redhat.com, js...@redhat.com > Sent: Thursday, August 3, 2017 6:45:17 PM > Subject:

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

* Alberto Garcia (be...@igalia.com) wrote: > On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: > > --- a/vl.c > > +++ b/vl.c > > @@ -4787,8 +4787,8 @@ int main(int argc, char **argv, char **envp) > > replay_disable_events(); > > iothread_stop_all(); > > > >

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: > --- a/vl.c > +++ b/vl.c > @@ -4787,8 +4787,8 @@ int main(int argc, char **argv, char **envp) > replay_disable_events(); > iothread_stop_all(); > > -bdrv_close_all(); > pause_all_vcpus(); > +

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On 07/17/2017 06:26 AM, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: >> On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> There's a rare exit seg if the guest is

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > There's a rare exit seg if the guest is accessing > > IO during exit. > > It's always hitting the

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There's a rare exit seg if the guest is accessing > IO during exit. > It's always hitting the atomic_inc(>in_flight) with a NULL > bs. This was added recently

[Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

From: "Dr. David Alan Gilbert" There's a rare exit seg if the guest is accessing IO during exit. It's always hitting the atomic_inc(>in_flight) with a NULL bs. This was added recently in 99723548 but I don't see it as the cause. Flip vl.c around so we pause the cpus before