Re: [Qemu-devel] [PATCH] xics: Don't call icp_kvm_realize() from icp_realize()

2019-06-17 Thread Greg Kurz
On Mon, 17 Jun 2019 15:46:14 +0200 Cédric Le Goater wrote: > On 17/06/2019 15:25, Greg Kurz wrote: > > kvm_kernel_irqchip is set by xics_kvm_init() which is always called after > > icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the > > 'dual' machine". > > I think we st

Re: [Qemu-devel] [PATCH] xics: Don't call icp_kvm_realize() from icp_realize()

2019-06-17 Thread Cédric Le Goater
On 17/06/2019 15:25, Greg Kurz wrote: > kvm_kernel_irqchip is set by xics_kvm_init() which is always called after > icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the > 'dual' machine". I think we still need it for CPU hotplug. C. > This is thus dead code. Drop it. > >

[Qemu-devel] [PATCH] xics: Don't call icp_kvm_realize() from icp_realize()

2019-06-17 Thread Greg Kurz
kvm_kernel_irqchip is set by xics_kvm_init() which is always called after icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the 'dual' machine". This is thus dead code. Drop it. Signed-off-by: Greg Kurz --- hw/intc/xics.c |8 1 file changed, 8 deletions(-) dif