Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-22 Thread Eduardo Habkost
On Wed, May 22, 2019 at 10:42:56AM +0200, Jiri Denemark wrote: > On Fri, May 10, 2019 at 17:23:13 -0300, Eduardo Habkost wrote: > > On Fri, May 10, 2019 at 01:33:03PM +0200, Jiri Denemark wrote: > > > On Thu, May 09, 2019 at 13:08:25 -0300, Eduardo Habkost wrote: > > > > On Thu, May 09, 2019 at 05:

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-22 Thread Eduardo Habkost
On Wed, May 22, 2019 at 10:27:41AM +0200, Jiri Denemark wrote: > On Fri, May 10, 2019 at 17:32:03 -0300, Eduardo Habkost wrote: > > On Thu, May 09, 2019 at 06:36:18PM +0200, Jiri Denemark wrote: > > > On Thu, May 09, 2019 at 18:06:03 +0200, Igor Mammedov wrote: > > > > On Thu, 9 May 2019 10:56:17 -

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-22 Thread Jiri Denemark
On Fri, May 10, 2019 at 17:23:13 -0300, Eduardo Habkost wrote: > On Fri, May 10, 2019 at 01:33:03PM +0200, Jiri Denemark wrote: > > On Thu, May 09, 2019 at 13:08:25 -0300, Eduardo Habkost wrote: > > > On Thu, May 09, 2019 at 05:26:16PM +0200, Jiri Denemark wrote: > > > > On Thu, May 09, 2019 at 10:

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-22 Thread Jiri Denemark
On Fri, May 10, 2019 at 17:32:03 -0300, Eduardo Habkost wrote: > On Thu, May 09, 2019 at 06:36:18PM +0200, Jiri Denemark wrote: > > On Thu, May 09, 2019 at 18:06:03 +0200, Igor Mammedov wrote: > > > On Thu, 9 May 2019 10:56:17 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Thu, May 09, 2019

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-10 Thread Eduardo Habkost
On Thu, May 09, 2019 at 06:36:18PM +0200, Jiri Denemark wrote: > On Thu, May 09, 2019 at 18:06:03 +0200, Igor Mammedov wrote: > > On Thu, 9 May 2019 10:56:17 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > > > Would this unavailable-fe

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-10 Thread Eduardo Habkost
On Fri, May 10, 2019 at 01:33:03PM +0200, Jiri Denemark wrote: > On Thu, May 09, 2019 at 13:08:25 -0300, Eduardo Habkost wrote: > > On Thu, May 09, 2019 at 05:26:16PM +0200, Jiri Denemark wrote: > > > On Thu, May 09, 2019 at 10:56:17 -0300, Eduardo Habkost wrote: > > > > On Thu, May 09, 2019 at 03:

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-10 Thread Jiri Denemark
On Thu, May 09, 2019 at 13:08:25 -0300, Eduardo Habkost wrote: > On Thu, May 09, 2019 at 05:26:16PM +0200, Jiri Denemark wrote: > > On Thu, May 09, 2019 at 10:56:17 -0300, Eduardo Habkost wrote: > > > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > > > Would this unavailable-feat

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-09 Thread Jiri Denemark
On Thu, May 09, 2019 at 18:06:03 +0200, Igor Mammedov wrote: > On Thu, 9 May 2019 10:56:17 -0300 > Eduardo Habkost wrote: > > > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > > Would this unavailable-features property contain only canonical names of > > > the features or all p

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-09 Thread Eduardo Habkost
On Thu, May 09, 2019 at 05:26:16PM +0200, Jiri Denemark wrote: > On Thu, May 09, 2019 at 10:56:17 -0300, Eduardo Habkost wrote: > > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > > Would this unavailable-features property contain only canonical names of > > > the features or all

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-09 Thread Igor Mammedov
On Thu, 9 May 2019 10:56:17 -0300 Eduardo Habkost wrote: > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > On Mon, Apr 22, 2019 at 20:47:40 -0300, Eduardo Habkost wrote: > > > Currently, libvirt uses the "filtered-features" QOM property at > > > runtime to ensure no feature was

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-09 Thread Jiri Denemark
On Thu, May 09, 2019 at 10:56:17 -0300, Eduardo Habkost wrote: > On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > > Would this unavailable-features property contain only canonical names of > > the features or all possible aliases of all features? For example, > > "tsc-adjust" can al

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-09 Thread Eduardo Habkost
On Thu, May 09, 2019 at 03:35:37PM +0200, Jiri Denemark wrote: > On Mon, Apr 22, 2019 at 20:47:40 -0300, Eduardo Habkost wrote: > > Currently, libvirt uses the "filtered-features" QOM property at > > runtime to ensure no feature was accidentally disabled on VCPUs > > because it's not available on t

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-09 Thread Jiri Denemark
On Mon, Apr 22, 2019 at 20:47:40 -0300, Eduardo Habkost wrote: > Currently, libvirt uses the "filtered-features" QOM property at > runtime to ensure no feature was accidentally disabled on VCPUs > because it's not available on the host. > > However, the code for "feature-words" assumes that all mi

[Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-04-22 Thread Eduardo Habkost
Currently, libvirt uses the "filtered-features" QOM property at runtime to ensure no feature was accidentally disabled on VCPUs because it's not available on the host. However, the code for "feature-words" assumes that all missing features have a corresponding CPUID bit, which is not true for MSR-