Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-25 Thread Stefan Hajnoczi
On Mon, Jul 24, 2017 at 07:32:29PM +0300, Lluís Vilanova wrote: > Denis V Lunev writes: > > > On 07/24/2017 05:43 PM, Lluís Vilanova wrote: > >> Denis V Lunev writes: > >> > >>> On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Lluís Vilanova
Denis V Lunev writes: > On 07/24/2017 05:43 PM, Lluís Vilanova wrote: >> Denis V Lunev writes: >> >>> On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Current trace system have a drawback: parameters of

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Philippe Mathieu-Daudé
On 07/24/2017 09:17 AM, Denis V. Lunev wrote: On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: Current trace system have a drawback: parameters of trace functions are calculated even if corresponding tracepoint is

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Denis V. Lunev
On 07/24/2017 05:43 PM, Lluís Vilanova wrote: > Denis V Lunev writes: > >> On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: >>> On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: Current trace system have a drawback: parameters of trace functions are

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Lluís Vilanova
Denis V Lunev writes: > On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: >> On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> Current trace system have a drawback: parameters of trace functions >>> are calculated even if corresponding tracepoint is disabled. Also, it

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Denis V. Lunev
On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Current trace system have a drawback: parameters of trace functions >> are calculated even if corresponding tracepoint is disabled. Also, it >> looks like trace

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Current trace system have a drawback: parameters of trace functions > are calculated even if corresponding tracepoint is disabled. Also, it > looks like trace function are not actually inlined by compiler (at > least

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 08:04:17PM +0300, Lluís Vilanova wrote: > Vladimir Sementsov-Ogievskiy writes: > > > Current trace system have a drawback: parameters of trace functions > > are calculated even if corresponding tracepoint is disabled. Also, it > > looks like trace function are not actually

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Denis V. Lunev
On 07/24/2017 02:07 PM, Lluís Vilanova wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 21.07.2017 20:04, Lluís Vilanova wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Current trace system have a drawback: parameters of trace functions are calculated even if corresponding

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Lluís Vilanova
Vladimir Sementsov-Ogievskiy writes: > 21.07.2017 20:04, Lluís Vilanova wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Current trace system have a drawback: parameters of trace functions >>> are calculated even if corresponding tracepoint is disabled. Also, it >>> looks like trace

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Vladimir Sementsov-Ogievskiy
21.07.2017 20:04, Lluís Vilanova wrote: Vladimir Sementsov-Ogievskiy writes: Current trace system have a drawback: parameters of trace functions are calculated even if corresponding tracepoint is disabled. Also, it looks like trace function are not actually inlined by compiler (at least for

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-21 Thread Lluís Vilanova
Vladimir Sementsov-Ogievskiy writes: > Current trace system have a drawback: parameters of trace functions > are calculated even if corresponding tracepoint is disabled. Also, it > looks like trace function are not actually inlined by compiler (at > least for me). > Here is a fix proposal: move

[Qemu-devel] [PATCH 0/2] improve tracing

2017-07-21 Thread Vladimir Sementsov-Ogievskiy
Current trace system have a drawback: parameters of trace functions are calculated even if corresponding tracepoint is disabled. Also, it looks like trace function are not actually inlined by compiler (at least for me). Here is a fix proposal: move from function call to macros. Patch 02 is an