Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-04 Thread David Gibson
On Thu, Jan 05, 2017 at 08:53:07AM +0800, 赵小强 wrote: > Ok！ > > Just one more comment： > After check the code flow, It's clear that the initialized memory > region must be add to address space by calling > memory_region_add_subregion in platform code before it can be > accessed. Yes.. but I don't

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-04 Thread 赵小强
Ok！ Just one more comment： After check the code flow, It's clear that the initialized memory region must be add to address space by calling memory_region_add_subregion in platform code before it can be accessed. Best wishes ！ > 在 2017年1月5日，08:20，David Gibson 写道：

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-04 Thread David Gibson
On Wed, Jan 04, 2017 at 05:04:02PM +, Peter Maydell wrote: > On 4 January 2017 at 03:28, David Gibson wrote: > > On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote: > >> Hi，david： > >> > >>To my understanding，what must be put in the realize function is > >>

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-04 Thread Peter Maydell
On 4 January 2017 at 03:28, David Gibson wrote: > On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote: >> Hi，david： >> >>To my understanding，what must be put in the realize function is >>code which depends on property values. What's the benefit of >>

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-04 Thread 赵小强
Hmm，sounds reasonable. I will take a look. PS: guys, some other comments about this? Best wishes ！ >> 在 2017年1月4日，11:28，David Gibson 写道： >> >> On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote: >> Hi，david： >> >> To my understanding，what must be put in the

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-03 Thread David Gibson
On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote: > Hi，david： > >To my understanding，what must be put in the realize function is >code which depends on property values. What's the benefit of >moving memory region initialization into realize function? I can >not figure out,

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-03 Thread 赵小强
Hi，david： To my understanding，what must be put in the realize function is code which depends on property values. What's the benefit of moving memory region initialization into realize function? I can not figure out, can you make some explanations? Thanks for your review. Best wishes

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-02 Thread David Gibson
On Sat, Dec 31, 2016 at 09:18:27AM +0800, xiaoqiang zhao wrote: > This is some QOM'ify work relate with ppc. > See each commit message for details. > > xiaoqiang zhao (4): > hw/gpio: QOM'ify mpc8xxx.c > hw/ppc: QOM'ify e500.c > hw/ppc: QOM'ify ppce500_spin.c > hw/ppc: QOM'ify spapr_vio.c

[Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2016-12-30 Thread xiaoqiang zhao
This is some QOM'ify work relate with ppc. See each commit message for details. xiaoqiang zhao (4): hw/gpio: QOM'ify mpc8xxx.c hw/ppc: QOM'ify e500.c hw/ppc: QOM'ify ppce500_spin.c hw/ppc: QOM'ify spapr_vio.c hw/gpio/mpc8xxx.c | 20 +++- hw/ppc/e500.c | 17