Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-25 Thread Kevin Wolf
Am 22.03.2019 um 14:21 hat Kevin Wolf geschrieben: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-23 Thread Nir Soffer
On Fri, Mar 22, 2019 at 10:47 PM Eric Blake wrote: > On 3/22/19 3:22 PM, Nir Soffer wrote: > > > Thanks for fixing this! This will be a very important performance fix for > > importing > > VMs. > > > > The change description sounds good to me. > > > > Can you make these patches available on some

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 3:22 PM, Nir Soffer wrote: > Thanks for fixing this! This will be a very important performance fix for > importing > VMs. > > The change description sounds good to me. > > Can you make these patches available on some git repo to make it easy to > test? Based on commit titles, this

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Nir Soffer
On Fri, Mar 22, 2019 at 3:22 PM Kevin Wolf wrote: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 8:21 AM, Kevin Wolf wrote: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this provides only an

[Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Kevin Wolf
If qemu-img convert sees that the target image isn't zero-initialised yet, it tries to do an efficient zero write for the whole image first to save the overhead of repeated explicit zero writes during the conversion. Obviously, this provides only an advantage if the pre-zeroing is actually