Re: [Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-08 Thread Aurelien Jarno
On Fri, Jan 07, 2011 at 05:50:51PM +, Peter Maydell wrote: > On 7 January 2011 16:01, Aurelien Jarno wrote: > > My other concern is about the definition of the individual bits in the > > flags. I have seen that you have tried to summarize the usage in the > > patch 6, but the masks and shifts

Re: [Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-07 Thread Peter Maydell
On 7 January 2011 16:01, Aurelien Jarno wrote: > My other concern is about the definition of the individual bits in the > flags. I have seen that you have tried to summarize the usage in the > patch 6, but the masks and shifts are still duplicated in different > files, which may leads to mistakes

Re: [Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-07 Thread David Turner
For what is worth, this was fixed in the Android emulator with the following patch: http://android.git.kernel.org/?p=platform/external/qemu.git;a=commit;h=01e9608cb62901d13b330f851a260a2082e81a06

Re: [Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-07 Thread Peter Maydell
On 7 January 2011 16:01, Aurelien Jarno wrote: > My other concern is about the definition of the individual bits in the > flags. I have seen that you have tried to summarize the usage in the > patch 6, but the masks and shifts are still duplicated in different > files, which may leads to mistakes

Re: [Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-07 Thread Peter Maydell
On 7 January 2011 16:01, Aurelien Jarno wrote: > In overall I think it's the correct approach to fix the issue, this is > a really good cleanup. I have tested this patch series, and it clearly > improve armv7 support. However I am surprised it doesn't fix the issue > mentioned in https://bugs.laun

Re: [Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-07 Thread Aurelien Jarno
Hi, On Fri, Jan 07, 2011 at 03:06:27PM +, Peter Maydell wrote: > This patchset corrects a number of places in the ARM translation code > which were generating code which was dependent on values in the CPUState > structure which might change at runtime. This is a bad idea for two > reasons. Fir

[Qemu-devel] [PATCH 0/7] target-arm: Translate based on TB flags, not CPUState

2011-01-07 Thread Peter Maydell
This patchset corrects a number of places in the ARM translation code which were generating code which was dependent on values in the CPUState structure which might change at runtime. This is a bad idea for two reasons. Firstly, we might try to reuse the generated code later when the assumptions ba