Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-22 Thread Kevin Wolf
Am 21.11.2010 03:19, schrieb Alexander Graf: On 19.11.2010, at 14:46, Kevin Wolf wrote: Am 19.11.2010 14:08, schrieb Alexander Graf: On 19.11.2010, at 10:15, Kevin Wolf wrote: Am 18.11.2010 19:43, schrieb Alexander Graf: Then I believe that core.c is now a mixture of some generic ATA

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-20 Thread Alexander Graf
On 19.11.2010, at 14:46, Kevin Wolf wrote: Am 19.11.2010 14:08, schrieb Alexander Graf: On 19.11.2010, at 10:15, Kevin Wolf wrote: Am 18.11.2010 19:43, schrieb Alexander Graf: Then I believe that core.c is now a mixture of some generic ATA code (that is also used by SATA) and the Legacy

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-20 Thread Alexander Graf
On 19.11.2010, at 10:12, Stefan Hajnoczi wrote: On Thu, Nov 18, 2010 at 11:24 PM, Alexander Graf ag...@suse.de wrote: linux-uztg:~ # dd if=/dev/sdc of=/dev/null bs=10M count=300 iflag=direct That's a big block size. bs=8k is interesting too because we see the per-request overhead. Since

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-19 Thread Kevin Wolf
Am 18.11.2010 19:43, schrieb Alexander Graf: On 18.11.2010, at 14:26, Kevin Wolf kw...@redhat.com wrote: Hi Alex, Am 18.11.2010 04:27, schrieb Alexander Graf: This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7.

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-19 Thread Gerd Hoffmann
Hi, As I would rather have something working we can base on in the tree, so whoever volunteers for the refactoring (hint!) knows how to design the interfaces, I am not sure how much is reasonable within this patch set. I guess I have to read this as: You want to drop the code into the

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-19 Thread Kevin Wolf
Am 19.11.2010 12:56, schrieb Gerd Hoffmann: Hi, As I would rather have something working we can base on in the tree, so whoever volunteers for the refactoring (hint!) knows how to design the interfaces, I am not sure how much is reasonable within this patch set. I guess I have to read

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-19 Thread Alexander Graf
On 19.11.2010, at 10:15, Kevin Wolf wrote: Am 18.11.2010 19:43, schrieb Alexander Graf: On 18.11.2010, at 14:26, Kevin Wolf kw...@redhat.com wrote: Hi Alex, Am 18.11.2010 04:27, schrieb Alexander Graf: This patch adds support for AHCI emulation. I have tested and verified it works

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-19 Thread Kevin Wolf
Am 19.11.2010 14:08, schrieb Alexander Graf: On 19.11.2010, at 10:15, Kevin Wolf wrote: Am 18.11.2010 19:43, schrieb Alexander Graf: Then I believe that core.c is now a mixture of some generic ATA code (that is also used by SATA) and the Legacy IDE code. SATA doesn't seem to interact with

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-19 Thread Gerd Hoffmann
Hi, Also to catch up on Gerd's point - whatever refactoring we do, we will basically have to break migration. There is no way we can change all the internal state and structure and maintain binary compatibility with the old save states. On the other hand it would be a *real* pity to drag

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-18 Thread Kevin Wolf
Hi Alex, Am 18.11.2010 04:27, schrieb Alexander Graf: This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports NCQ, so multiple read or write requests can be outstanding at the same time.

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-18 Thread Alexander Graf
On 18.11.2010, at 14:26, Kevin Wolf kw...@redhat.com wrote: Hi Alex, Am 18.11.2010 04:27, schrieb Alexander Graf: This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports NCQ, so multiple

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-18 Thread Ryan Harper
* Alexander Graf ag...@suse.de [2010-11-18 12:49]: On 18.11.2010, at 14:26, Kevin Wolf kw...@redhat.com wrote: Hi Alex, Am 18.11.2010 04:27, schrieb Alexander Graf: This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-18 Thread Alexander Graf
On 18.11.2010, at 21:06, Ryan Harper wrote: Speaking of fast, do you have any numbers around ACHI vs IDE (not that I need any convincing that we can do better than IDE); just curious. To test the raw link speed, I usually take a tmpfs backed sparse raw file and pass it to the guest. Inside

[Qemu-devel] [PATCH 00/10] AHCI emulation support v2

2010-11-17 Thread Alexander Graf
This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports NCQ, so multiple read or write requests can be outstanding at the same time. The code is however not fully optimized yet. I'm fairly sure