On Apr 9, 2019, at 12:15, Philippe Mathieu-Daudé wrote:
> Since you did changes in the CFI table, I think we should add a tests
> verifying the table is correctly generated for all you FlashConfig entries.
In v3 of the patch, I added tests for the CFI table values
- device length
- sector len
On Apr 9, 2019, at 12:15, Philippe Mathieu-Daudé wrote:
> Since you did changes in the CFI table, I think we should add a tests
> verifying the table is correctly generated for all you FlashConfig entries.
That's a good idea. Some of the values are essentially arbitrary (e.g., how
long an er
On 4/9/19 5:55 PM, Stephen Checkoway wrote:
> Hi Phil,
>
>> On Apr 9, 2019, at 06:34, Philippe Mathieu-Daudé wrote:
>>
>> Hi Stephen,
>>
>> [Cc'ing Markus and Laszlo, we have similar interest in pflash01 testing]
>>
>> On 4/8/19 10:55 PM, Stephen Checkoway wrote:
>>> The goal of this patch series
Hi Phil,
> On Apr 9, 2019, at 06:34, Philippe Mathieu-Daudé wrote:
>
> Hi Stephen,
>
> [Cc'ing Markus and Laszlo, we have similar interest in pflash01 testing]
>
> On 4/8/19 10:55 PM, Stephen Checkoway wrote:
>> The goal of this patch series implement the following AMD command-set
>> parallel
Hi Stephen,
[Cc'ing Markus and Laszlo, we have similar interest in pflash01 testing]
On 4/8/19 10:55 PM, Stephen Checkoway wrote:
> The goal of this patch series implement the following AMD command-set parallel
> flash functionality:
> - flash interleaving;
> - nonuniform sector sizes;
> - erase
Patchew URL:
https://patchew.org/QEMU/cover.1554755001.git.stephen.checko...@oberlin.edu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: cover.1554755001.git.stephen.checko...@oberlin.edu
Subject: [Qemu-devel] [PATCH 00/10] block
The goal of this patch series implement the following AMD command-set parallel
flash functionality:
- flash interleaving;
- nonuniform sector sizes;
- erase suspend/resume commands; and
- multi-sector erase.
During refactoring and implementation, I discovered several bugs that are
fixed here as we
