Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-10-01 Thread Richard Henderson
On 10/01/2013 08:54 AM, Alexander Graf wrote: > Just make sure you actually check for feature bits on every instruction (which > I think you do, but the current code is way too magical to me to really > understand it anymore) so that we can always implement a z900 cpu type later > on. Yes, the co

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-10-01 Thread Alexander Graf
On 10/01/2013 05:52 PM, Richard Henderson wrote: On 10/01/2013 08:48 AM, Alexander Graf wrote: On 09/30/2013 09:15 PM, Richard Henderson wrote: On 09/30/2013 11:03 AM, Alexander Graf wrote: On 09/23/2013 04:04 PM, Richard Henderson wrote: Rather than simply hard-coding them in STFL instructio

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-10-01 Thread Alexander Graf
On 09/30/2013 09:15 PM, Richard Henderson wrote: On 09/30/2013 11:03 AM, Alexander Graf wrote: On 09/23/2013 04:04 PM, Richard Henderson wrote: Rather than simply hard-coding them in STFL instruction. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 3 +++ target-s390x/cpu

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-10-01 Thread Richard Henderson
On 10/01/2013 08:48 AM, Alexander Graf wrote: > On 09/30/2013 09:15 PM, Richard Henderson wrote: >> On 09/30/2013 11:03 AM, Alexander Graf wrote: >>> On 09/23/2013 04:04 PM, Richard Henderson wrote: Rather than simply hard-coding them in STFL instruction. Signed-off-by: Richard Hende

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-09-30 Thread Richard Henderson
On 09/30/2013 11:03 AM, Alexander Graf wrote: > On 09/23/2013 04:04 PM, Richard Henderson wrote: >> Rather than simply hard-coding them in STFL instruction. >> >> Signed-off-by: Richard Henderson >> --- >> target-s390x/cpu.c | 3 +++ >> target-s390x/cpu.h | 1 + >> target-s390x/tr

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-09-30 Thread Alexander Graf
On 09/23/2013 04:04 PM, Richard Henderson wrote: Rather than simply hard-coding them in STFL instruction. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 3 +++ target-s390x/cpu.h | 1 + target-s390x/translate.c | 10 +- 3 files changed, 9 insertions(+), 5 de

[Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-09-23 Thread Richard Henderson
Rather than simply hard-coding them in STFL instruction. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 3 +++ target-s390x/cpu.h | 1 + target-s390x/translate.c | 10 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/target-s390x/cpu.c b/target-s