Re: [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

2015-12-13 Thread David Gibson
On Fri, Dec 11, 2015 at 06:58:12AM -0700, Eric Blake wrote: > On 12/10/2015 05:11 PM, David Gibson wrote: > > Current ppc_set_compat() returns -1 for errors, and also (unconditionally) > > reports an error message. The caller in h_client_architecture_support() > > may then report it again using

Re: [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > Current ppc_set_compat() returns -1 for errors, and also (unconditionally) > reports an error message. The caller in h_client_architecture_support() > may then report it again using an outdated fprintf(). > > Clean this up by using the modern error

Re: [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

2015-12-11 Thread Thomas Huth
On 11/12/15 01:11, David Gibson wrote: > Current ppc_set_compat() returns -1 for errors, and also (unconditionally) > reports an error message. The caller in h_client_architecture_support() > may then report it again using an outdated fprintf(). > > Clean this up by using the modern error

[Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

2015-12-10 Thread David Gibson
Current ppc_set_compat() returns -1 for errors, and also (unconditionally) reports an error message. The caller in h_client_architecture_support() may then report it again using an outdated fprintf(). Clean this up by using the modern error reporting mechanisms. Signed-off-by: David Gibson