Re: [Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it

2018-01-09 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:53 -0300, wrote: > struct mbuf_ptr { > struct mbuf *mptr; > uint32_t dummy; > -} QEMU_PACKED; > +}; > #else > struct mbuf_ptr { > struct mbuf *mptr; > -} QEMU_PACKED; > +}; > @@ -199,7 +199,7 @@ struct ipovly { >

Re: [Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it

2018-01-08 Thread Thomas Huth
On 08.01.2018 18:28, Philippe Mathieu-Daudé wrote: > theses structures are not serialized and often store host pointers. Patch looks fine at a quick glance... did you check that migration still works (while there is network traffic going on in the guest)? Thomas

[Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it

2018-01-08 Thread Philippe Mathieu-Daudé
theses structures are not serialized and often store host pointers. slirp/ip_input.c:159:43: warning: taking address of packed member 'ip_link' of class or structure 'ipq' may result in an unaligned pointer value [-Waddress-of-packed-member] for (l =