Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-04 Thread Stefan Hajnoczi
On Wed, Aug 3, 2011 at 9:49 AM, Paolo Bonzini pbonz...@redhat.com wrote: In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a segmentation fault. An easy way to trigger it is

Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-04 Thread Kevin Wolf
Am 04.08.2011 15:35, schrieb Stefan Hajnoczi: On Wed, Aug 3, 2011 at 9:49 AM, Paolo Bonzini pbonz...@redhat.com wrote: In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a

[Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-03 Thread Paolo Bonzini
In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a segmentation fault. An easy way to trigger it is eject -f cd during installation (during media test if the installer does

Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-03 Thread Christoph Hellwig
On Wed, Aug 03, 2011 at 10:49:04AM +0200, Paolo Bonzini wrote: In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a segmentation fault. An easy way to trigger it is eject -f cd